use common retry policy builder function#1247
Open
symbiogenesis wants to merge 1 commit intoMimetis:masterfrom
Open
use common retry policy builder function#1247symbiogenesis wants to merge 1 commit intoMimetis:masterfrom
symbiogenesis wants to merge 1 commit intoMimetis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, there was an inconsistency with the retry policy.
The
WaitAndRetryForeverlogic would run whenTransactionModeisAllOrNothingin two cases. And would run when notAllOrNothingin the other case.Also, this means that with a transaction mode of
None, this will still do a retry. But, whenTransactionModeisNone, that seems really destructive to keep trying.I recommend a consistent policy.
I also recommend to not retry when the mode is
None, but to just throw the exception. However, I didn't make that change here. I could do so, if you like the idea.